[libc] Fix incorrect macro usage in shared/sign.h #150140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: Leandro Lacerda (leandrolcampos) ChangesThis patch corrects the The previous change (#150083) incorrectly used the Full diff: https://github.com/llvm/llvm-project/pull/150140.diff 1 Files Affected:
diff --git a/libc/shared/sign.h b/libc/shared/sign.h
index faa8648b96439..2029b52b89441 100644
--- a/libc/shared/sign.h
+++ b/libc/shared/sign.h
@@ -15,7 +15,7 @@
namespace LIBC_NAMESPACE_DECL {
namespace shared {
-using LIBC_NAMESPACE_DECL::Sign;
+using LIBC_NAMESPACE::Sign;
} // namespace shared
} // namespace LIBC_NAMESPACE_DECL
|
lntue
approved these changes
Jul 22, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
This patch corrects the `using`-declaration in `libc/shared/sign.h`. The previous change (llvm#150083) incorrectly used the `LIBC_NAMESPACE_DECL` macro. This is corrected to use `LIBC_NAMESPACE`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch corrects the
using-declaration inlibc/shared/sign.h.The previous change (#150083) incorrectly used the
LIBC_NAMESPACE_DECLmacro. This is corrected to useLIBC_NAMESPACE.